Skip to content

Fix#2761: Loading of different image on Peer Review on rotation #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Fix#2761: Loading of different image on Peer Review on rotation #2929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion app/src/main/java/fr/free/nrw/commons/review/ReviewActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,17 @@ public class ReviewActivity extends AuthenticatedActivity {
@Inject
DeleteHelper deleteHelper;

final String SAVED_MEDIA = "saved_media";
private Media media;

@Override
protected void onSaveInstanceState(Bundle outState) {
super.onSaveInstanceState(outState);
if (media != null) {
outState.putParcelable(SAVED_MEDIA, media);
}
}

/**
* Consumers should be simply using this method to use this activity.
*
Expand Down Expand Up @@ -102,7 +113,11 @@ protected void onCreate(Bundle savedInstanceState) {
pagerIndicator.setViewPager(reviewPager);
progressBar.setVisibility(View.VISIBLE);

runRandomizer(); //Run randomizer whenever everything is ready so that a first random image will be added
if (savedInstanceState != null) {
updateImage(savedInstanceState.getParcelable(SAVED_MEDIA)); // Use existing media if we have one
} else {
runRandomizer(); //Run randomizer whenever everything is ready so that a first random image will be added
}

btnSkipImage.setOnClickListener(view -> runRandomizer());

Expand Down Expand Up @@ -130,6 +145,7 @@ public boolean runRandomizer() {

@SuppressLint("CheckResult")
private void updateImage(Media media) {
this.media = media;
String fileName = media.getFilename();
if (fileName.length() == 0) {
ViewUtil.showShortSnackbar(drawerLayout, R.string.error_review);
Expand Down