Fixes #2337 - Show captions of image in media details (conflicts fixed) #2933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Tests fails because of changes, please someone with RxJava knowledge review this. |
Collaborator
|
@neslihanturan I have raised a pr for the same on your branch. Tests pass with the same on my local machine. Please have a look : ) |
Neslihanturan sp2710 new
* updated unit test for fetchCaptionByFilename()
Fixed failing test cases
ashishkumar468
approved these changes
Apr 29, 2019
Collaborator
|
@neslihanturan I just noticed that xml api's have been used in the PR, would you mind switching them to the corresponding json one ? |
ashishkumar468
added a commit
that referenced
this pull request
May 1, 2019
|
Thanks for working on this. It was long due. |
Member
|
@misaochan Is it OK to merge this after converting the XML call to JSON? |
Contributor
|
Data client just provides an instance of OkhttpClient. The API would be written as a custom call. So there should be no extra effort required for using it via the data client :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes the conflicts from #2662 which solves #2337 to be able to merge changes, the code of @Sp2710 was already working perfectly.