Skip to content

Revert "Fixes #2337 - Show captions of image in media details (confli… #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2019

Conversation

ashishkumar468
Copy link
Collaborator

Revert 2933, uses xml apis. we have agreed to use the json apis

@codecov-io
Copy link

Codecov Report

Merging #2934 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2934      +/-   ##
=========================================
- Coverage    3.71%   3.69%   -0.03%     
=========================================
  Files         246     246              
  Lines       12243   12219      -24     
  Branches     1084    1083       -1     
=========================================
- Hits          455     451       -4     
+ Misses      11754   11734      -20     
  Partials       34      34
Impacted Files Coverage Δ
app/src/main/java/fr/free/nrw/commons/Media.java 6.41% <ø> (+0.12%) ⬆️
...fr/free/nrw/commons/media/MediaDetailFragment.java 0% <ø> (ø) ⬆️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java 0% <ø> (ø) ⬆️
...n/java/fr/free/nrw/commons/MediaDataExtractor.java 94.73% <100%> (+6.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9b7ba...ad0bd9d. Read the comment docs.

@ashishkumar468 ashishkumar468 merged commit c8a58bf into master May 1, 2019
@domdomegg domdomegg deleted the revert-2933-sp2710-new branch June 16, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants