Skip to content

Fixes #3532 #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ashishkumar468
Copy link
Collaborator

Description (required)
Ask gitignore to not ignore .idea/codeStyles/codeStyleConfig.xml & not .idea/codeStyles/

Fixes #3532 Issue with gitignore

What changes did you make and why?
Ask gitignore to not ignore .idea/codeStyles/codeStyleConfig.xml & not .idea/codeStyles/

* Ask gitignore to not ignore .idea/codeStyles/codeStyleConfig.xml & not .idea/codeStyles/
@codecov-io
Copy link

Codecov Report

Merging #3533 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3533   +/-   ##
========================================
  Coverage      7.19%   7.19%           
  Complexity      297     297           
========================================
  Files           264     264           
  Lines         11840   11840           
  Branches        961     961           
========================================
  Hits            852     852           
  Misses        10919   10919           
  Partials         69      69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af131a9...79576d6. Read the comment docs.

@misaochan misaochan requested a review from macgills March 17, 2020 09:22
@macgills
Copy link
Contributor

This means our codestyle won't be in git. the Project.xml absolutely needs to be there

@ashishkumar468
Copy link
Collaborator Author

@macgills Yes, gitignore wont ignore codeStyleConfig as in changes to that will be reflected, but those to Project.xml wont be added

@macgills
Copy link
Contributor

But Project.xml is the codestyle. If you do this and somebody new clones the project then they don't get it.

@ashishkumar468 ashishkumar468 deleted the bugfix/gitignore-codeStyles branch March 19, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with gitignore
3 participants