Skip to content

Changed the strings #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Changed the strings #4024

wants to merge 7 commits into from

Conversation

isdl03
Copy link

@isdl03 isdl03 commented Nov 8, 2020

Description (required)

Fixes #2874

What changes did you make and why?
We have replaced all such strings which contains the word success or failure with more understandable strings.

Tests performed (required)
Tested on Pixel 2 with API level 28.

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

@codecov-io
Copy link

codecov-io commented Nov 8, 2020

Codecov Report

Merging #4024 (2ff40b3) into master (9d99c25) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4024      +/-   ##
============================================
+ Coverage     10.50%   10.65%   +0.15%     
- Complexity      466      476      +10     
============================================
  Files           335      343       +8     
  Lines         12663    12821     +158     
  Branches        991      995       +4     
============================================
+ Hits           1330     1366      +36     
- Misses        11266    11387     +121     
- Partials         67       68       +1     
Impacted Files Coverage Δ Complexity Δ
...e/nrw/commons/location/LocationServiceManager.java 8.42% <0.00%> (-0.28%) 0.00% <0.00%> (ø%)
...java/fr/free/nrw/commons/upload/UploadService.java 0.84% <0.00%> (-0.01%) 1.00% <0.00%> (ø%)
...c/main/java/fr/free/nrw/commons/AboutActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...n/java/fr/free/nrw/commons/auth/LoginActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../java/fr/free/nrw/commons/upload/UploadClient.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ava/fr/free/nrw/commons/review/ReviewActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...va/fr/free/nrw/commons/campaigns/CampaignView.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...va/fr/free/nrw/commons/explore/SearchActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...a/fr/free/nrw/commons/profile/ProfileActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../fr/free/nrw/commons/di/ActivityBuilderModule.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d99c25...2ff40b3. Read the comment docs.

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR ideally should edit only strings.xml file. As you can see from diff tab, currently it includes several irrelevant edits.

@sivaraam
Copy link
Member

sivaraam commented Dec 2, 2020

Closing per #2874 (comment)

@sivaraam sivaraam closed this Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants