-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Changed the strings #4024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the strings #4024
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4024 +/- ##
============================================
+ Coverage 10.50% 10.65% +0.15%
- Complexity 466 476 +10
============================================
Files 335 343 +8
Lines 12663 12821 +158
Branches 991 995 +4
============================================
+ Hits 1330 1366 +36
- Misses 11266 11387 +121
- Partials 67 68 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR ideally should edit only strings.xml file. As you can see from diff tab, currently it includes several irrelevant edits.
Closing per #2874 (comment) |
Description (required)
Fixes #2874
What changes did you make and why?
We have replaced all such strings which contains the word success or failure with more understandable strings.
Tests performed (required)
Tested on Pixel 2 with API level 28.
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.