Update WLM camaign dates [Do not merge now, merge only after alpha release] #4584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neslihanturan
requested changes
Aug 26, 2021
Collaborator
neslihanturan
left a comment
There was a problem hiding this comment.
Hey @ashishkumar468 , I have tested this PR. Some unexpected date format and wrong dates appears on the banner. Also I am sure I am on the correct commit.
Collaborator
Author
|
Sorry for the trouble @neslihanturan, let me look into this |
Collaborator
Author
|
|
misaochan
reviewed
Aug 26, 2021
| if(date.getDay()>=1 && date.getMonth()>=9 && date.getDay()<=31 && date.getMonth()<=10 ){ | ||
| public static boolean isMonumentsEnabled(final Date date) { | ||
| if (date.getDate() >= 1 && date.getMonth() >= 8 && date.getDate() <= 30 | ||
| && date.getMonth() <= 8) { |
Member
There was a problem hiding this comment.
Shouldn't the month be == 9 exactly? We want it to be active only from 1 Sep to 30 Sep.
Collaborator
Author
There was a problem hiding this comment.
Its actually 0 index based
Member
|
Required for v3.1.0 beta. Cannot release without, because then people who don't update their app will be getting WLM markers after the competition is over. |
Collaborator
|
Hey hi, here are test results:
|
Member
|
As discussed with Nes, this works now, merging. |
misaochan
added a commit
that referenced
this pull request
Sep 16, 2021
* Cherry-Picked NPE fix from master (#4569) * Fix notification bug #4547 (#4570) * Make Single Query for Nearby and WLM pins (#4573) * Merge nearby and monument queries * Bug Fix- query resource path change on shouldQueryForMonuments * Bug Fixes 1. Propagate exceptions for nearby API calls to caller 2. Fix too much work on main thread exception in NearbyParentFragment * Modify parameters for Nearby query * Bug fix- current location marker (#4580) * Move WLM template below geolocation template (#4582) * Modify string for WLM upload notice * Fix bug #4583 (#4591) * Fix bug #4585 by updating kotlin and acra version (#4592) * Fixes #4554 - only use WLM2021 template for countries that are included in it (#4574) * Fixes #4554 1. For WLM uploads reverse geo code and see if the country code is supported -only then is the WLM upload flow triggered, otherwise usual nearby uploads happen 2. Bug Fix - Current Location marker and area * Fixed compile error added after rebasing * Bug fix for country code in reverse geo code * Update WLM camaign dates [Do not merge now, merge only after alpha release] (#4584) * Updates dates for WML campaign * Bug fix- campaign dates * Fixed logic for WLM enablement - stick to the month of September * Add countries supported by WLM2021 template, except Italy * Versioning for v3.1.0 * Update changelog.md * Fix empty default lang bug (#4608) * Fix bug #4583 * Fix empty default lang bug * Fixes #4595 - Updated nearby query (#4622) * Fixes #4595 - Updated nearby query * Removed logic to replace local language in nearby query - that might acccidentally replace other strings * Fetch property location in usual nearby query * Remove duplicate line (#4626) * Change "learn more" link to new wiki * Add Sweden's P3426 to property filter * Fixes #4601 - 1. Handle possible exceptions in upload file from stash 2. Modify MWException, as error is nullable, update getTitle and getMessage to rever that (#4627) * Versioning for v3.1.1 * Update changelog.md * Updated DB version to rever integrity Co-authored-by: Madhur Gupta <30932899+madhurgupta10@users.noreply.github.com> Co-authored-by: Josephine Lim <josephinelim86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #4552
What changes did you make and why?
Updated the dates for the campaign from 1 Sep to 30 Sep
Tests performed (required)
Tested betaDebug on API 29