Skip to content

Fixes #4215 - Swiping on the last item in explore featured tab takes you to uploaded via mobile #4729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

Pratham2305
Copy link
Contributor

Description (required)

Fixes #4215

What changes did you make and why?

  • Disabled the ParentViewPager scrolling on clicking the media.

Tests performed (required)

Tested betaDebug on Pixel 3 with API level 29.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #4729 (f7d8f3d) into master (b7be493) will increase coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4729      +/-   ##
============================================
+ Coverage     39.72%   39.81%   +0.09%     
- Complexity     1734     1740       +6     
============================================
  Files           357      357              
  Lines         15163    15164       +1     
  Branches       1303     1303              
============================================
+ Hits           6023     6038      +15     
+ Misses         8709     8697      -12     
+ Partials        431      429       -2     
Impacted Files Coverage Δ
...e/nrw/commons/explore/ExploreListRootFragment.java 0.00% <0.00%> (ø)
...fr/free/nrw/commons/review/ReviewPagerAdapter.java 30.76% <0.00%> (-38.47%) ⬇️
...ava/fr/free/nrw/commons/review/ReviewActivity.java 47.28% <0.00%> (-3.11%) ⬇️
...ns/upload/categories/UploadCategoriesFragment.java 88.40% <0.00%> (+1.44%) ⬆️
.../free/nrw/commons/repository/UploadRepository.java 24.13% <0.00%> (+1.72%) ⬆️
...va/fr/free/nrw/commons/category/CategoriesModel.kt 49.01% <0.00%> (+1.96%) ⬆️
.../java/fr/free/nrw/commons/review/ReviewHelper.java 88.88% <0.00%> (+5.55%) ⬆️
...w/commons/upload/categories/BaseDelegateAdapter.kt 47.05% <0.00%> (+11.76%) ⬆️
.../nrw/commons/category/CategoryContentProvider.java 26.78% <0.00%> (+16.07%) ⬆️
...in/java/fr/free/nrw/commons/data/DBOpenHelper.java 40.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7be493...f7d8f3d. Read the comment docs.

@4D17Y4 4D17Y4 merged commit bd00ce2 into commons-app:master Dec 13, 2021
@4D17Y4
Copy link
Contributor

4D17Y4 commented Dec 13, 2021

thanks @Pratham2305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swiping on the last item in explore featured tab takes you to uploaded via mobile.
2 participants