Fixes #4589 :- The empty screen while no images found in custom picture selector #4858

Rishavgupta12345 · 2022-02-25T13:56:21Z

The empty screen while no images found in custom picture selector #4589 is fixed now

codecov · 2022-02-25T14:15:57Z

Codecov Report

Merging #4858 (2d207a1) into master (87b9648) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4858      +/-   ##
============================================
- Coverage     50.66%   50.54%   -0.12%     
+ Complexity     2231     2223       -8     
============================================
  Files           338      338              
  Lines         15531    15552      +21     
  Branches       1358     1361       +3     
============================================
- Hits           7869     7861       -8     
- Misses         7079     7104      +25     
- Partials        583      587       +4

Impacted Files	Coverage Δ
...ommons/customselector/ui/selector/ImageFragment.kt	`54.54% <0.00%> (-5.46%)`	⬇️
.../nrw/commons/category/CategoryContentProvider.java	`12.50% <0.00%> (-14.29%)`	⬇️
...ree/nrw/commons/contributions/ContributionDao.java	`6.25% <0.00%> (-12.50%)`	⬇️
...w/commons/upload/categories/BaseDelegateAdapter.kt	`35.29% <0.00%> (-11.77%)`	⬇️
...commons/contributions/ContributionsRepository.java	`41.66% <0.00%> (-8.34%)`	⬇️
...ns/contributions/ContributionsLocalDataSource.java	`16.66% <0.00%> (-4.17%)`	⬇️
...r/free/nrw/commons/explore/media/MediaConverter.kt	`92.85% <0.00%> (-2.39%)`	⬇️
...va/fr/free/nrw/commons/category/CategoriesModel.kt	`57.62% <0.00%> (-1.70%)`	⬇️
...ns/upload/categories/UploadCategoriesFragment.java	`86.95% <0.00%> (-1.45%)`	⬇️
.../commons/contributions/ContributionViewHolder.java	`79.16% <0.00%> (-0.48%)`	⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b9648...2d207a1. Read the comment docs.

4D17Y4

Just tested it and it works.
But I don't think this is the best way to handle such exceptions. It would be better if the logic is added in folder and image fragments. There is a handleResult function in both fragments which could be all you need.

Let me know if you think otherwise.

4D17Y4 · 2022-02-25T14:15:59Z

app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt

            val lastOpenFolderId: Long = prefs.getLong(FOLDER_ID, 0L)
            val lastOpenFolderName: String? = prefs.getString(FOLDER_NAME, null)
            val lastItemId: Long = prefs.getLong(ITEM_ID, 0)
            lastOpenFolderName?.let { onFolderClick(lastOpenFolderId, it, lastItemId) }
        }
+
+            if(isImageGalleryEmpty())


Add a comment for this if statement, similar to the one above.
Indentation.

4D17Y4 · 2022-02-25T14:16:34Z

app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt

+    /**
+     * Checks for no image in gallery.
+     */
+        private fun isImageGalleryEmpty(): Boolean {


Indentation.

what do you mean ?

There should be only 4 spaces before private (same number as before /**).

okay got it

4D17Y4 · 2022-02-25T14:17:27Z

app/src/main/res/layout/activity_custom_selector.xml

+      app:layout_constraintHorizontal_bias="0.66"
+      app:layout_constraintStart_toStartOf="parent"
+      app:layout_constraintTop_toTopOf="@+id/fragment_container"
+      app:layout_constraintVertical_bias="0.481"></LinearLayout>


Use /> when element is empty.

4D17Y4 · 2022-02-25T14:17:58Z

app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt

+        {
+            val linearLayout: LinearLayout = findViewById<View>(R.id.linear_layout_noimage) as LinearLayout
+            val textView = TextView(this)
+            textView.text = "No Image Found"


Use string localization for the text.

how can I translate this string to all possible languages, translation is done by other capable contributors, creating other issues in the repo , and moreover not all the strings have been localized yet , its still in progress

Please check how localization is done in other parts of the app. It is the standard Android way, so if you are not familiar with it I recommend doing a tutorial to get the idea. If you find strings in the app UI that are not localized, please create an issue to flag them, thanks a lot! :-)

@nicolas-raoul I have seen youtube tutorial which says that I have to manually translate the text in all the different languages by searching in google translator , but there is no automatic translation feature so it will be a very hectic task to manually translate in all languages

Rishavgupta12345

@4D17Y4 @nicolas-raoul done

nicolas-raoul · 2022-02-26T13:42:48Z

app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt

+        {
+            val linearLayout: LinearLayout = findViewById<View>(R.id.linear_layout_noimage) as LinearLayout
+            val textView = TextView(this)
+            textView.text = "No Image Found"


Please check how localization is done in other parts of the app. It is the standard Android way, so if you are not familiar with it I recommend doing a tutorial to get the idea. If you find strings in the app UI that are not localized, please create an issue to flag them, thanks a lot! :-)

Rishavgupta12345

@nicolas-raoul

Rishavgupta12345 · 2022-02-26T15:05:34Z

app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt

+        {
+            val linearLayout: LinearLayout = findViewById<View>(R.id.linear_layout_noimage) as LinearLayout
+            val textView = TextView(this)
+            textView.text = "No Image Found"


@nicolas-raoul I have seen youtube tutorial which says that I have to manually translate the text in all the different languages by searching in google translator , but there is no automatic translation feature so it will be a very hectic task to manually translate in all languages

Rishavgupta12345 · 2022-02-26T15:06:03Z

app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/CustomSelectorActivity.kt

+    /**
+     * Checks for no image in gallery.
+     */
+        private fun isImageGalleryEmpty(): Boolean {


okay got it

4D17Y4 · 2022-02-26T15:31:01Z

Just tested it and it works. But I don't think this is the best way to handle such exceptions. It would be better if the logic is added in folder and image fragments. There is a handleResult function in both fragments which could be all you need.

Let me know if you think otherwise.

@Rishavgupta12345

Rishavgupta12345 · 2022-02-27T13:55:10Z

Just tested it and it works. But I don't think this is the best way to handle such exceptions. It would be better if the logic is added in folder and image fragments. There is a handleResult function in both fragments which could be all you need.
Let me know if you think otherwise.

@Rishavgupta12345

@4D17Y4 @nicolas-raoul done in a simpler way as you have said me to do, also the localization issue is also solved.🙂

4D17Y4

Nice work on Image fragment.
Image fragment is the one you see when you tap on a specific folder in custom selector. We can do this same thing in folder fragment in case there are no folders.

4D17Y4 · 2022-02-27T17:53:41Z

app/src/main/res/layout/activity_custom_selector.xml

+
+    <LinearLayout
+      android:id="@+id/linear_layout_noimage"
+      android:layout_width="204dp"


Do not hardcode the values. As android screens have varied dimensions it might not look perfect on some screen sizes. Instead you can use match_parent or wrap_content that way the layout adjusts depending on the screen size.

4D17Y4 · 2022-02-27T17:53:56Z

app/src/main/res/layout/activity_custom_selector.xml

+
+        <TextView
+          android:id="@+id/no_images_found"
+          android:layout_width="172dp"


No hardcoded values.

Rishavgupta12345 · 2022-02-28T05:10:02Z

a problem occured in this brach so I am closing this pull request and creating a fresh one , Sorry for the Inconvenience

Empty screen while no images found in custom picture selector

6e61073

4D17Y4 reviewed Feb 25, 2022

View reviewed changes

required changes done

2b01392

Rishavgupta12345 commented Feb 26, 2022

View reviewed changes

nicolas-raoul requested changes Feb 26, 2022

View reviewed changes

minor requested change

0b9da29

Rishavgupta12345 commented Feb 26, 2022

View reviewed changes

Rishavgupta12345 added 2 commits February 27, 2022 19:20

other way of doing it

9800ca6

bug

2d207a1

4D17Y4 reviewed Feb 27, 2022

View reviewed changes

Rishavgupta12345 closed this Feb 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #4589 :- The empty screen while no images found in custom picture selector #4858

Fixes #4589 :- The empty screen while no images found in custom picture selector #4858

Rishavgupta12345 commented Feb 25, 2022

codecov bot commented Feb 25, 2022 •

edited

Loading

4D17Y4 left a comment •

edited

Loading

4D17Y4 Feb 25, 2022

Rishavgupta12345 Feb 26, 2022

4D17Y4 Feb 25, 2022

Rishavgupta12345 Feb 26, 2022

nicolas-raoul Feb 26, 2022

Rishavgupta12345 Feb 26, 2022

4D17Y4 Feb 25, 2022

Rishavgupta12345 Feb 26, 2022

4D17Y4 Feb 25, 2022

Rishavgupta12345 Feb 26, 2022

nicolas-raoul Feb 26, 2022

Rishavgupta12345 Feb 26, 2022

Rishavgupta12345 left a comment •

edited

Loading

nicolas-raoul Feb 26, 2022

Rishavgupta12345 left a comment

Rishavgupta12345 Feb 26, 2022

Rishavgupta12345 Feb 26, 2022

4D17Y4 commented Feb 26, 2022

Rishavgupta12345 commented Feb 27, 2022 •

edited

Loading

4D17Y4 left a comment •

edited

Loading

4D17Y4 Feb 27, 2022

4D17Y4 Feb 27, 2022

Rishavgupta12345 commented Feb 28, 2022

Fixes #4589 :- The empty screen while no images found in custom picture selector #4858

Fixes #4589 :- The empty screen while no images found in custom picture selector #4858

Conversation

Rishavgupta12345 commented Feb 25, 2022

codecov bot commented Feb 25, 2022 • edited Loading

Codecov Report

4D17Y4 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rishavgupta12345 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rishavgupta12345 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

4D17Y4 commented Feb 26, 2022

Rishavgupta12345 commented Feb 27, 2022 • edited Loading

4D17Y4 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rishavgupta12345 commented Feb 28, 2022

codecov bot commented Feb 25, 2022 •

edited

Loading

4D17Y4 left a comment •

edited

Loading

Rishavgupta12345 left a comment •

edited

Loading

Rishavgupta12345 commented Feb 27, 2022 •

edited

Loading

4D17Y4 left a comment •

edited

Loading