Skip to content

Empty screen while no images found in custom picture selector #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ayan-10 opened this issue Aug 29, 2021 · 3 comments · Fixed by #4884
Closed

Empty screen while no images found in custom picture selector #4589

Ayan-10 opened this issue Aug 29, 2021 · 3 comments · Fixed by #4884
Assignees

Comments

@Ayan-10
Copy link
Contributor

Ayan-10 commented Aug 29, 2021

Summary:

When there is no image in the device, Custom picture selector opens with a white empty screen.

Steps to reproduce:

  1. Make sure there is no image in the device
  2. Click the + icon
  3. Select custom picture selector

What did you expect the app to do, and what did you see instead?

There should be some information like "No images found" (with some graphic)

Device and Android version:

Pixel 2 API 30

Commons app version:

Betadebug latest master

Screen-shots:

Would you like to work on the issue?
YES

@4D17Y4
Copy link
Contributor

4D17Y4 commented Aug 29, 2021

Thanks for the issue @Ayan-10
Would be a nice improvement.

To add to the issue, a similar message can be shown in the image fragment when the folder is empty (delete images in the current folder and return to the custom selector).

@Rishavgupta12345
Copy link
Contributor

@nicolas-raoul i would like to work on this issue please assign me

@nicolas-raoul
Copy link
Member

I would be in favor of just showing "No images found" and no graphic (unless the app already embeds a usable graphic) in order to not make the app heavier for this edge user case.
Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment