Skip to content

Fixes #4589 :- The empty screen while no images found in custom picture selector [bug] #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Rishavgupta12345
Copy link
Contributor

Fixes #4589 :- The empty screen while no images found in custom picture selector @madhurgupta10 merge this pull reqeust and the old problem with the test will be solved

@nicolas-raoul
Copy link
Member

I get this error when running unit tests on this branch:

e: /Users/nicolasraoul/src/commons-app/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/FolderFragment.kt: (118, 17): Unresolved reference: new_no_image
e: /Users/nicolasraoul/src/commons-app/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt: (157, 17): Unresolved reference: new_no_image

CI is showing the same error. Would you mind trying to fix it?

@Rishavgupta12345
Copy link
Contributor Author

I get this error when running unit tests on this branch:

e: /Users/nicolasraoul/src/commons-app/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/FolderFragment.kt: (118, 17): Unresolved reference: new_no_image
e: /Users/nicolasraoul/src/commons-app/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt: (157, 17): Unresolved reference: new_no_image

CI is showing the same error. Would you mind trying to fix it?

strange!! I am not getting any error while running them

@devarsh-mavani-19
Copy link
Contributor

I get this error when running unit tests on this branch:

e: /Users/nicolasraoul/src/commons-app/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/FolderFragment.kt: (118, 17): Unresolved reference: new_no_image
e: /Users/nicolasraoul/src/commons-app/app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt: (157, 17): Unresolved reference: new_no_image

CI is showing the same error. Would you mind trying to fix it?

strange!! I am not getting any error while running them

@nicolas-raoul the problem happened when you merge the pull request of #4863 , so IF you can then please revert that merge and un merge it . Then makeing all the test cases correct I will create a Fresh pull reqeust

@Rishavgupta12345 I don't think you can undo the merge. Can you please write the tests so that it does not fail? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty screen while no images found in custom picture selector
3 participants