Skip to content

Fix #4930 : change the nearby bookmark icon color#4932

Merged
nicolas-raoul merged 1 commit intocommons-app:masterfrom
JackyLiang522:master
Apr 14, 2022
Merged

Fix #4930 : change the nearby bookmark icon color#4932
nicolas-raoul merged 1 commit intocommons-app:masterfrom
JackyLiang522:master

Conversation

@JackyLiang522
Copy link
Contributor

Description (required)

Fixes #4930

The original black icon cannot be seen in the dark theme. The icon color is then changed to orange so that it is visible in both themes.

Tests performed (required)

Screenshots (for UI changes only)
Light theme:

Dark theme:

The original black icon cannot be seen in the dark theme. The color is changed to orange so that it is visible in both themes.
Copy link
Member

@misaochan misaochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #4932 (5435352) into master (0d25c24) will increase coverage by 0.73%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4932      +/-   ##
============================================
+ Coverage     51.42%   52.15%   +0.73%     
- Complexity     2327     2376      +49     
============================================
  Files           345      344       -1     
  Lines         16194    16268      +74     
  Branches       1430     1429       -1     
============================================
+ Hits           8327     8485     +158     
+ Misses         7236     7151      -85     
- Partials        631      632       +1     
Impacted Files Coverage Δ
...w/commons/upload/categories/CategoriesPresenter.kt 66.66% <0.00%> (-33.34%) ⬇️
...ns/upload/categories/UploadCategoriesFragment.java 58.21% <0.00%> (-30.19%) ⬇️
...a/fr/free/nrw/commons/OkHttpConnectionFactory.java 52.27% <0.00%> (-20.46%) ⬇️
...xplore/depictions/WikidataItemDetailsActivity.java 71.90% <0.00%> (-0.46%) ⬇️
...va/fr/free/nrw/commons/explore/SearchActivity.java 86.36% <0.00%> (-0.25%) ⬇️
...e/nrw/commons/explore/ExploreListRootFragment.java 91.95% <0.00%> (-0.19%) ⬇️
...ategory/CategoryEditSearchRecyclerViewAdapter.java
...ee/nrw/commons/media/MediaDetailPagerFragment.java 25.00% <0.00%> (+0.12%) ⬆️
...nrw/commons/description/DescriptionEditActivity.kt 88.09% <0.00%> (+0.14%) ⬆️
...e/nrw/commons/upload/UploadMediaDetailAdapter.java 61.50% <0.00%> (+0.19%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4834303...5435352. Read the comment docs.

@nicolas-raoul nicolas-raoul merged commit f492d95 into commons-app:master Apr 14, 2022
@nicolas-raoul
Copy link
Member

Thanks Justin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nearby filter bookmark icon invisible in dark mode

3 participants