Fix #4930 : change the nearby bookmark icon color#4932
Merged
nicolas-raoul merged 1 commit intocommons-app:masterfrom Apr 14, 2022
Merged
Fix #4930 : change the nearby bookmark icon color#4932nicolas-raoul merged 1 commit intocommons-app:masterfrom
nicolas-raoul merged 1 commit intocommons-app:masterfrom
Conversation
The original black icon cannot be seen in the dark theme. The color is changed to orange so that it is visible in both themes.
Codecov Report
@@ Coverage Diff @@
## master #4932 +/- ##
============================================
+ Coverage 51.42% 52.15% +0.73%
- Complexity 2327 2376 +49
============================================
Files 345 344 -1
Lines 16194 16268 +74
Branches 1430 1429 -1
============================================
+ Hits 8327 8485 +158
+ Misses 7236 7151 -85
- Partials 631 632 +1
Continue to review full report at Codecov.
|
nicolas-raoul
approved these changes
Apr 14, 2022
Member
|
Thanks Justin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #4930
The original black icon cannot be seen in the dark theme. The icon color is then changed to orange so that it is visible in both themes.
Tests performed (required)
Screenshots (for UI changes only)


Light theme:
Dark theme: