Showing an overlay dialog when a nearby item is tapped #569
Conversation
| String query = WIKIDATA_QUERY_TEMPLATE.replace("${RADIUS}", "" + radius) | ||
|
|
||
| String query = FileUtils.readFromFile(context, "queries/nearby_query.txt"); | ||
|
|
There was a problem hiding this comment.
I believe this way the file will be loaded every time a query is sent. Can the file be read only once and stored somewhere?
I would suggest moving readFromFile() to getInstance() and storing the query in an instance field.
EDIT: We would also have to avoid calling getInstance() for every query, too...
There was a problem hiding this comment.
@maskaravivek are you working on this? If not, may I? (actually I have gone half way for that.)
There was a problem hiding this comment.
I am currently not working on it. It would be great if you could complete the thing and create a PR.
|
After pressing "read article" I was sent to the Wikidata page on the class (e.g. "museum"), not the instance (e.g. https://www.wikidata.org/wiki/Q10856362). Is this intended? Great work, by the way! |
|
Yeah, the class seems to have more information than the instance, don't you think? |
|
Will merge anyway, @maskaravivek says they will fix it the file loading in next patch. |
|
@misaochan I believe @whym understands that Wikidata gets open, but wonders why the "museum" page gets opened rather than the page of the item itself "Daimyo Clock Museum". |
Attached screenshots.
List View
Map View