Read once and reuse the query file's content #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2834a15 to
7739085
Compare
| @@ -13,7 +13,7 @@ SELECT | |||
| SERVICE wikibase:around { | |||
| ?item wdt:P625 ?location. | |||
| bd:serviceParam wikibase:center "Point(${LONG} ${LAT})"^^geo:wktLiteral. | |||
| bd:serviceParam wikibase:radius "${RADIUS}" . # Radius in kilometers. | |||
| bd:serviceParam wikibase:radius "${RAD}" . # Radius in kilometers. | |||
There was a problem hiding this comment.
Why do you want to change the param to RAD
There was a problem hiding this comment.
I slightly prefer it because it will make code look more aligned.
.replace("${RAD}", String.format(Locale.ROOT, "%.2f", radius))
.replace("${LAT}", String.format(Locale.ROOT, "%.4f", cur.latitude))
There was a problem hiding this comment.
In your previous PR I guess you forgot to make the change in the nearby_query.rb, so the nearby places stopped loading. Can you test it thoroughly once? I will be happy to merge it then. :)
There was a problem hiding this comment.
The nearby list and map work okay for me with these devices.
- Android 6.0.1, API 23 (real device)
- Android 7.1.1, API 25 (emulator)
- Android 5.1.1, API 22 (emulator)
Sorry about the oversight - the previous patch was incomplete.
|
Is this ready to merge? |
|
I don't see a remaining issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #569 (comment)
Also fixes the bug introduced in #599 (the variable names RAD and RADIUS being inconsistent)