(fixes #5856) Unchanged / inconsistent username in different pages . (#5856) #5856 #5860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Code looks good! |
Member
|
Actually I just tested and it seems to work. |
Contributor
Author
|
I've removed the draft status/ |
nicolas-raoul
approved these changes
Oct 16, 2024
Member
nicolas-raoul
left a comment
There was a problem hiding this comment.
Tested, fixes the issue in Explore
Member
|
Thanks a lot! :-) |
parneet-guraya
added a commit
to parneet-guraya/apps-android-commons
that referenced
this pull request
Feb 24, 2025
Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
Merged
parneet-guraya
added a commit
to parneet-guraya/apps-android-commons
that referenced
this pull request
Feb 24, 2025
Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
parneet-guraya
added a commit
to parneet-guraya/apps-android-commons
that referenced
this pull request
Mar 3, 2025
Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
nicolas-raoul
pushed a commit
that referenced
this pull request
Mar 8, 2025
* revert changes from #5860 Signed-off-by: parneet-guraya <gurayaparneet@gmail.com> * read author prop instead Signed-off-by: parneet-guraya <gurayaparneet@gmail.com> * Use user prop if author is empty or null Signed-off-by: parneet-guraya <gurayaparneet@gmail.com> * fix test Signed-off-by: parneet-guraya <gurayaparneet@gmail.com> --------- Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
sonalyadav1
pushed a commit
to sonalyadav1/apps-android-commons
that referenced
this pull request
May 22, 2025
* revert changes from commons-app#5860 Signed-off-by: parneet-guraya <gurayaparneet@gmail.com> * read author prop instead Signed-off-by: parneet-guraya <gurayaparneet@gmail.com> * Use user prop if author is empty or null Signed-off-by: parneet-guraya <gurayaparneet@gmail.com> * fix test Signed-off-by: parneet-guraya <gurayaparneet@gmail.com> --------- Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5856
What changes did you make and why?
Use the getAuthor(metadata) instead of imageInfo.user
The original code used imageInfo.user, which simply fetched the registered username of the media uploader. In contrast, the new code employs getAuthor(metadata), pulling the author information from the ExtMetadata object to emphasize the custom author name. This adjustment is deliberate, ensuring that the licensing name (custom author name) is showcased in the user profile rather than the default registered username.
Tests performed (required)
Tested {ProdDebug} on {MuMu emulator Android 12} with API level {API 34}.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.