Skip to content

Fix empty username #6209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2025
Merged

Conversation

parneet-guraya
Copy link
Contributor

Fixes #6198

What changes did you make and why?

Revert changes of #5860;
The bug was due to reading the wrong property but this PR changed the data in the model Media instead. Reverted the change and made it read the correct prop instead.

Correct custom author name in both contributions and explore screens (bug was it was incorrect in the explore)


Fixed empty author field; Use user if author is null or empty.

Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
Copy link

github-actions bot commented Mar 3, 2025

✅ Generated APK variants!

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with an out-of-copyright image I uploaded via web:

before:
Screenshot_20250308-222221.png

after:
Screenshot_20250308-221847.png

interesting that the author is not shown, but at least it shows something now. Thanks!

@nicolas-raoul nicolas-raoul merged commit 972bf78 into commons-app:main Mar 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] User doesn't show in the contibutions page
2 participants