Convert upload to kotlin (part 2) #6069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Dec 23, 2024
There was a problem hiding this comment.
I am always getting a crash when trying to upload a picture with this branch. On the main branch I can successfully upload pictures.
Would you mind checking?
Thanks a lot! 🙂
screen-20241224-080501.mp4
java.lang.NullPointerException: Parameter specified as non-null is null: method fr.free.nrw.commons.upload.UploadItem.<init>, parameter place
at fr.free.nrw.commons.upload.UploadItem.<init>(Unknown Source:19)
at fr.free.nrw.commons.upload.UploadModel.createAndAddUploadItem(UploadModel.java:148)
at fr.free.nrw.commons.upload.UploadModel.preProcessImage(UploadModel.java:92)
at fr.free.nrw.commons.repository.UploadRepository.preProcessImage(UploadRepository.kt:181)
at fr.free.nrw.commons.upload.mediaDetails.UploadMediaPresenter.receiveImage(UploadMediaPresenter.java:121)
at fr.free.nrw.commons.upload.mediaDetails.UploadMediaDetailFragment.init(UploadMediaDetailFragment.java:229)
at fr.free.nrw.commons.upload.mediaDetails.UploadMediaDetailFragment.onViewCreated(UploadMediaDetailFragment.java:198)
at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:2987)
at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:546)
at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2189)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2100)
at androidx.fragment.app.FragmentManager.execSingleAction(FragmentManager.java:1971)
at androidx.fragment.app.BackStackRecord.commitNowAllowingStateLoss(BackStackRecord.java:311)
at androidx.fragment.app.FragmentStatePagerAdapter.finishUpdate(FragmentStatePagerAdapter.java:274)
at androidx.viewpager.widget.ViewPager.populate(ViewPager.java:1244)
at androidx.viewpager.widget.ViewPager.populate(ViewPager.java:1092)
at androidx.viewpager.widget.ViewPager.onMeasure(ViewPager.java:1622)
at android.view.View.measure(View.java:28375)
at android.widget.RelativeLayout.measureChildHorizontal(RelativeLayout.java:735)
at android.widget.RelativeLayout.onMeasure(RelativeLayout.java:481)
at android.view.View.measure(View.java:28375)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7026)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
at androidx.appcompat.widget.ContentFrameLayout.onMeasure(ContentFrameLayout.java:145)
at android.view.View.measure(View.java:28375)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7026)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1608)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:878)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
at android.view.View.measure(View.java:28375)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7026)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
at android.view.View.measure(View.java:28375)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7026)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1608)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:878)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
at android.view.View.measure(View.java:28375)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:7026)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
at com.android.internal.policy.DecorView.onMeasure(DecorView.java:735)
at android.view.View.measure(View.java:28375)
at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:4923)
at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:3324)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3629)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:3009)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:10514)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1566)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1575)
at android.view.Choreographer.doCallbacks(Choreographer.java:1175)
at android.view.Choreographer.doFrame(Choreographer.java:1104)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1549)
at android.os.Handler.handleCallback(Handler.java:991)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loopOnce(Looper.java:232)
at android.os.Looper.loop(Looper.java:317)
at android.app.ActivityThread.main(ActivityThread.java:8934)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:911)
|
I spotted that myself, and working on it. I fixed it on "part 3" but need to make the change on this branch too. |
cef2a92 to
a3744e9
Compare
|
Working great now, thanks! :-) |
nicolas-raoul
approved these changes
Dec 24, 2024
|
Maybe I spoke too early, I am getting OOM whenever an upload is launched, a few second after the license step. |
|
Working fine now, it must have unrelated, sorry for the noise! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: #5928
Part 2 of: #6014
This PR fills out most of the rest of the upload package, skipping 3 really large classes that will be in the final "part 3".