Feat: Improve UX for Edit Image button on non-JPEG files#6694
Merged
nicolas-raoul merged 3 commits intocommons-app:mainfrom Mar 6, 2026
Merged
Conversation
|
✅ Generated APK variants! |
neeldoshii
reviewed
Mar 1, 2026
app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragment.kt
Show resolved
Hide resolved
neeldoshii
approved these changes
Mar 1, 2026
Collaborator
Author
|
@neeldoshii, is this PR ready to be merged, or are there any improvements needed? 🙂 |
nicolas-raoul
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6693
What changes did you make and why?
UploadMediaDetailFragmentto keep the "Edit Image" button visible for all file types instead of hiding it for non-jpeg's0.5falpha effect to thellEditImagecontainer when a non-JPEG file (png, webp, or someother file formats) is detected to signify an inactive stateDialogUtilalert for non-JPEGs, explaining that editing is iscurrently only supported for jpeg's and suggesting third-party tools.Tests performed (required)
Tested ProDebug on Redmi Note 13 Pro with API level 35.
.jpgfile -> Button is fully opaque, and clicking it opens the Image Editor..pngfile -> Button appears greyed out, and clicking it displays the "Unsupported format" explanation dialog.Screenshots (for UI changes only)
For non-jpeg :
For jpeg:
