Clean up llm-dialog.ts

[bfollington]

• Refactor LLM tool aggregation
• Fix types
• Further cleanup

---

Summary by cubic

Consolidated LLM tool aggregation and tool-call execution in llm-dialog.ts to simplify charm tool handling and improve type safety. This reduces duplicated logic and makes read/run charm tools more predictable.

• Refactors

  • Added ToolCatalog and collectToolEntries to centralize tool discovery.
  • Generated consistent read/run charm tools via createCharmToolDefinitions.
  • Extracted tool-call flow into resolveToolCall, executeToolCalls, createToolResultMessages, and buildAssistantMessage.
  • Normalized input parsing with normalizeCharmPathSegments and extractRunArguments.
  • Simplified flattenTools and startRequest by using buildToolCatalog.

• Bug Fixes

  • Clear errors when paths resolve to handler streams (read) or not (run).
  • Consistent charm schema selection (loaded recipe or minimal fallback).
  • Correct handling of args provided under input.args or as top-level fields.
  • More robust resolution of legacy vs aggregated tools; informative error on unknown tools.

[cubic-dev-ai]

No issues found across 1 file