Finalize prepared statements #1990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes those to properly dispose of them. A future improvement is to only prepare the EXPORT statement once, and attach it to the Session or store.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/memory/space.ts">
<violation number="1" location="packages/memory/space.ts:788">
Wrap this statement in a try/finally so stmt.finalize() always runs even if stmt.get throws; otherwise a failing query will leak the prepared statement.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
packages/memory/space.ts
Outdated
| const of = transaction.sub; | ||
| const row = session.store.prepare(EXPORT).get({ the, of }) as | ||
| const stmt = session.store.prepare(EXPORT); | ||
| const row = stmt.get({ the, of }) as |
Contributor
There was a problem hiding this comment.
Wrap this statement in a try/finally so stmt.finalize() always runs even if stmt.get throws; otherwise a failing query will leak the prepared statement.
Prompt for AI agents
Address the following comment on packages/memory/space.ts at line 788:
<comment>Wrap this statement in a try/finally so stmt.finalize() always runs even if stmt.get throws; otherwise a failing query will leak the prepared statement.</comment>
<file context>
@@ -763,9 +784,11 @@ const commit = <Space extends MemorySpace>(
const of = transaction.sub;
- const row = session.store.prepare(EXPORT).get({ the, of }) as
+ const stmt = session.store.prepare(EXPORT);
+ const row = stmt.get({ the, of }) as
| StateRow
| undefined;
</file context>
✅ Addressed in f3d9ad7
Contributor
There was a problem hiding this comment.
Here's a PR: #1991 Always finalize prepared statements by adding try/finally (merges into #1990)
Review and merge it to apply the changes.
…hat I'm not using a generator function.
ellyxir
approved these changes
Oct 31, 2025
Contributor
ellyxir
left a comment
There was a problem hiding this comment.
this looks so much better, thanks! and i like getting rid of the generator even though i like generators, good call
jkomoros
pushed a commit
that referenced
this pull request
Nov 2, 2025
* Our existing code created prepared statements without finalizing them. This changes those to properly dispose of them. A future improvement is to only prepare the EXPORT statement once, and attach it to the Session or store. * Removed comment about finalize, since it's no longer applicable now that I'm not using a generator function. * better finally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the places where we use prepared statements to properly dispose of them.
A future improvement is to only prepare the EXPORT statement once, and attach it to the Session or store.
I also converted the selectFacts to not use a generator, since it isn't needed there, and complicates the statement disposal.
Summary by cubic
Finalize all prepared statements to prevent resource leaks and improve stability in memory store operations. Also change selectFacts to return an array so statements can be properly finalized.
Bug Fixes
Refactors
Written for commit f3d9ad7. Summary will update automatically on new commits.