Always finalize prepared statements by adding try/finally (merges into #1990) #1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes those to properly dispose of them. A future improvement is to only prepare the EXPORT statement once, and attach it to the Session or store.
…hat I'm not using a generator function.
|
This fix PR has been automatically closed because the parent PR #1990 was closed. If you still need this fix, please reopen the parent PR first, or create a new PR with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 PR by cubic
This PR addresses the comment in #1990 – Our existing code created prepared statements without finalizing them.
File:
packages/memory/space.tsLine: 788
Comment:
This fix was automatically generated. Please review the changes carefully before merging.
Summary by cubic
Always finalize prepared statements by wrapping stmt.get in a try/finally in packages/memory/space.ts. Prevents leaking prepared statements when a query throws.
Written for commit 495631d. Summary will update automatically on new commits.