Skip to content

feat(default-app): Simplify pattern list with clickable names and minimal actions #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
+27 −16
Merged

feat(default-app): Simplify pattern list with clickable names and minimal actions #2019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2a4a6b
feat(default-app): Simplify pattern list with clickable names and min…
Nov 5, 2025
3e04dfc
fix: Format code with deno fmt
Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 27 additions & 16 deletions packages/patterns/default-app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,29 +165,40 @@ export default recipe<CharmsListInput, CharmsListOutput>(

<ct-vscroll flex showScrollbar>
<ct-vstack gap="4" padding="6">
<style>
{`
.pattern-link {
cursor: pointer;
color: inherit;
text-decoration: none;
}
.pattern-link:hover {
text-decoration: underline;
}
`}
</style>
<h2>Patterns</h2>

<ct-table full-width hover>
<tbody>
{allCharms.map((charm) => (
<tr>
<td>{charm?.[NAME] || "Untitled Charm"}</td>
<td>
<ct-hstack gap="2">
<ct-button
size="sm"
onClick={visit({ charm })}
>
Visit
</ct-button>
<ct-button
size="sm"
variant="destructive"
onClick={removeCharm({ charm, allCharms })}
>
Remove
</ct-button>
</ct-hstack>
<a
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a real link (with an href) or a button here; the current without href is not keyboard accessible.

Prompt for AI agents 
Address the following comment on packages/patterns/default-app.tsx at line 186:

<comment>Use a real link (with an href) or a button here; the current &lt;a&gt; without href is not keyboard accessible.</comment>

<file context>
@@ -173,21 +183,21 @@ export default recipe&lt;CharmsListInput, CharmsListOutput&gt;(
-                            Remove
-                          &lt;/ct-button&gt;
-                        &lt;/ct-hstack&gt;
+                        &lt;a
+                          className=&quot;pattern-link&quot;
+                          onClick={visit({ charm })}
</file context>
Fix with Cubic

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a PR: #2022 Replace anchor without href with accessible link or button (merges into #2019)

Review and merge it to apply the changes.

className="pattern-link"
onClick={visit({ charm })}
>
{charm?.[NAME] || "Untitled Charm"}
</a>
</td>
<td>
<ct-button
size="sm"
variant="ghost"
onClick={removeCharm({ charm, allCharms })}
>
🗑️
</ct-button>
</td>
</tr>
))}
Expand Down