-
Notifications
You must be signed in to change notification settings - Fork 9
integration: create charm using ci, view in jumble #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jakedahn @bfollington opinions on changes in jumble to support easier testing? |
|
Questions:
rather than having "sleep" I wonder if we can have a more accurate "wait for green sync status"
|
|
fixed:
|
|
I also want to add running common-cli to validate the cells propagated out of the web context to common memory and back to cli |
jsantell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thank you! Some comments on alternatives and a potential race condition
|
Got rid of most sleeps, but seeing this error (sometimes) when clicking the button inbetween charm renders: https://jsr.io/@astral/astral/0.5.2/src/element_handle.ts#L192 TBD if waiting a bit helps, still seems ultimately intermittent |
this builds upon #516 - adding more testing