Skip to content

Conversation

@obulat
Copy link
Contributor

@obulat obulat commented Dec 4, 2020

Fixes

Fixes #205 by @panchovm

Description

This PR makes the whole completed step clickable and changes a completed step's border color when hovered. Also, it removes the border-radius from the stepper.

Screenshot

image

Technical details

This PR also refactors Stepper and *step components:

  • names of step parts were changed to be more in line with other stepper implementations (buefy, etc)
  • StepHeader with the Step Heading and Step Caption was extracted as a separate component, simplifying both Stepper and *Step components.
  • StepContent was greatly simplified by using dynamic components (component :is)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner December 4, 2020 05:31
@obulat obulat requested review from akmadian and removed request for a team December 4, 2020 05:31
# Conflicts:
#	src/components/LicenseText.vue
#	src/locales/en.json
#	tests/e2e/specs/AttributionDetailsStep.js
#	tests/e2e/specs/CopyrightWaiverStep.js
#	tests/e2e/specs/LicenseDetailsCard.js
#	tests/e2e/specs/Stepper.js
#	tests/unit/specs/components/ChooserStep.spec.js
#	tests/unit/specs/components/CopyrightWaiverStep.spec.js
# Conflicts:
#	src/components/AttributionDetailsStep.vue
#	tests/e2e/specs/LicenseCode.js
#	tests/unit/specs/components/__snapshots__/AttributionDetailsStep.spec.js.snap
@obulat
Copy link
Contributor Author

obulat commented Dec 9, 2020

These changes can be previewed here: https://nostalgic-villani-d2be5c.netlify.app/

@obulat obulat requested review from dhruvkb and zackkrida December 9, 2020 06:14
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the "Next" button becomes active (shouldn't the next step also be clickable)?
sshot

@obulat
Copy link
Contributor Author

obulat commented Dec 9, 2020

When the "Next" button becomes active (shouldn't the next step also be clickable)?
From what we've discussed with Anna, Francisco, and Kriti, the next steps should not be clickable. To go to the next step, the user has to click the 'Next' button.
Only the completed steps should be clickable so that the user can go back and check the answers, if necessary.

Thank you for your review!

@obulat obulat merged commit 05718c0 into creativecommons:master Dec 9, 2020
@obulat obulat deleted the stepper_style branch December 9, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clickable area in collapsed question

2 participants