Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into stepper_style
# Conflicts:
#	src/components/LicenseText.vue
#	src/locales/en.json
#	tests/e2e/specs/AttributionDetailsStep.js
#	tests/e2e/specs/CopyrightWaiverStep.js
#	tests/e2e/specs/LicenseDetailsCard.js
#	tests/e2e/specs/Stepper.js
#	tests/unit/specs/components/ChooserStep.spec.js
#	tests/unit/specs/components/CopyrightWaiverStep.spec.js
  • Loading branch information
obulat committed Dec 9, 2020
commit 60e9e6bc03f5595623fbe8cfbbd8c632988182a6
5 changes: 4 additions & 1 deletion src/components/LicenseText.vue
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ export default {
return this.shortName === 'CC0 1.0' ? 'license-use.richtext.marked-text' : 'license-use.richtext.licensed-text'
},
isCreatorLink() {
return this.attributionDetails.creatorName && this.creatorProfileUrl && this.isWeb
return this.creatorName && this.creatorProfileUrl && this.isWeb
},
licenseName() {
return this.attributionType === 'short' ? this.shortName : this.fullName
},
byString() {
return this.creatorName ? this.$t('license-use.richtext.by') : ''
Expand Down
2 changes: 1 addition & 1 deletion src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"copy-label": "Copy",
"copied-label": "Copied!",
"richtext": {
"full-text": "{workTitle} {by} {creator} {licenseMark} {license}",
"full-text": "{workTitle} {by} {creator}{licenseMark} {license}{print-instructions}",
"workTitle": "This work",
"by": "by",
"licensed-text": "is licensed under",
Expand Down
13 changes: 3 additions & 10 deletions tests/unit/specs/components/CopyrightWaiverStep.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,9 @@ describe('Test the functionality of Computed properties', () => {
wrapper.destroy()
})

// it('User checks confirmed then checks agreed', () => {
// const checkbox1 = wrapper.findAll('input[type="checkbox"]').at(1)
// checkbox1.setChecked()
//
// const checkbox = wrapper.findAll('input[type="checkbox"]').at(0)
// checkbox.setChecked()
//
// expect(wrapper.emitted().change[0]).toStrictEqual(['CW', 6, true])
// expect(wrapper.vm.copyrightWaiverAgreed).toBe(true)
// })
it('User checks confirmed then checks agreed', () => {
const checkbox1 = wrapper.findAll('input[type="checkbox"]').at(1)
checkbox1.setChecked()

const checkbox = wrapper.findAll('input[type="checkbox"]').at(0)
checkbox.setChecked()
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.