-
-
Notifications
You must be signed in to change notification settings - Fork 180
Move Help section to the end of the left column #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/components/Stepper.vue # tests/unit/specs/components/__snapshots__/Stepper.spec.js.snap
| }, | ||
| data: () => ({ | ||
| sixLicensesImg: '', | ||
| modals: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use an Array when keys are sequential integers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I didn't want to use an Array, I think, was I wanted the keys to start at 1, not at 0. With an array, I can't check if the modal is open with if modals[openModal], because when the open modal is at index 0, this returns false. I've solved it by checking if openModal !== null instead, and now it looks much cleaner, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can always create an Array with n+1 elements and leave the index 0 empty.
Fixes
Fixes #216 by @panchovm
Fixes #226 by @obulat
Fixes #209 by @panchovm
Description
This PR moves the Help section to the end of the left column to match v2 mockups.
Technical details
This PR is using Vue Vocabulary
AppModalcomponent to open Help links in the modals.Using the Vocabulary component also solves the problem of page jumping up whenever the help link has been clicked.
One point that still needs addressing, probably in the Vocabulary component, is the fact that the body can still be scrolled when a modal is open.
This PR also adds
markdown-itpackage for writing the longer Modal texts in markdown instead of html/plain text. This approach has two advantages:With markdown, it becomes:
So, the whole sentence is in one place, instead of being broken up into chunks.
Screenshots
Help Section:
Modal open:
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin