Skip to content

Conversation

@obulat
Copy link
Contributor

@obulat obulat commented Dec 14, 2020

Fixes

Fixes #[issue number] by @[issue author]

Description

When the user selects CC0, the Chooser opens a copyright waiver step. The user has to read the CC0 legal code and click a checkbox stating that they have read and agreed with it. Currently, the CC0 legal code is displayed inside a textbox. This is problematic for several reasons:

  1. This is not user-friendly: reading the deed inside a (smallish) textbook is very difficult.
  2. The text of the deed is inside the Chooser repo, and makes the bundle size larger.
  3. There should be a single source of truth for the license deeds and their translations. With the current setup, the translations might be done twice.

In this PR, I open the page of the CC0 legal code from the CC website in a modal when the user clicks on the link in the checkbox description (I have read and accept ...). This is also a familiar pattern for many users, and the deed window size is much larger, which makes it a much more user-friendly way to display the CC0 legal code.

Screenshots

image
image

Edited to add:
This PR is based on the work done in PR#247. The strings for help modals were changed to use markdown to simplify rendering. So, if decided to merge, this PR should be merged after #247

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner December 14, 2020 15:45
@obulat obulat requested review from akmadian and removed request for a team December 14, 2020 15:45
@obulat obulat merged commit 4a26904 into creativecommons:master Dec 20, 2020
@obulat obulat mentioned this pull request Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants