-
-
Notifications
You must be signed in to change notification settings - Fork 180
Open Copyright Waiver text from CC website in a modal #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
approved these changes
Dec 15, 2020
7 tasks
This reverts commit 6f09c17
# Conflicts: # src/locales/en.json
# Conflicts: # src/components/CopyrightWaiverStep.vue
# Conflicts: # src/App.vue
This was referenced Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #[issue number] by @[issue author]
Description
When the user selects CC0, the Chooser opens a copyright waiver step. The user has to read the CC0 legal code and click a checkbox stating that they have read and agreed with it. Currently, the CC0 legal code is displayed inside a textbox. This is problematic for several reasons:
In this PR, I open the page of the CC0 legal code from the CC website in a modal when the user clicks on the link in the checkbox description (I have read and accept ...). This is also a familiar pattern for many users, and the deed window size is much larger, which makes it a much more user-friendly way to display the CC0 legal code.
Screenshots
Edited to add:
This PR is based on the work done in PR#247. The strings for help modals were changed to use markdown to simplify rendering. So, if decided to merge, this PR should be merged after #247
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin