Linting and code formatting

[rohan-goel]

Fixes

Fixes #317 by @obulat

Description

• Changed indent form 4 to 2
• Added prettier and stylelint packages
• Added pre-commit support for both eslint and stylelint using vue-cli

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main or master).
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[obulat]

Wow, there are a lot of changes in this PR, thank you for your work ! :)
I have added some comments that need to be addressed inline.

[obulat]

Can you make stylelint only lint the content of 'src' folder? Otherwise it also tries to lint 'coverage', 'dist', or any other folders we might add later.

[rohan-goel]

There's ignoreFiles: ['docs/css/*'] property in stylelint.config.js which will prevent stylelint to lint this folder. So in future we can add other folder here. But still I'll make stylelint only lint the content of 'src' folder.

[rohan-goel]

Also does this mean eslint is also linting dist/js/* or vue-cli-service will handle it and will lint-staged lint 'dist' while committing or not?

[zackkrida]

I @rohan-goel we don't want the /dist folder linted, only the src/ files we write. I think @obulat's original approach to specify src/ is still the best approach.

[rohan-goel]

@zackkrida I have add "lint": "vue-cli-service lint && npx stylelint ./src/**/*.{vue,css} --fix" command in package.json. This will only lint src folder.

[Cronus1007]

@rohan-goel Update your brach to resolve the conflicts and also take a git pull

[rohan-goel]

@Cronus1007 I resolved merge conflicts but now I'm getting another test failed. Can you tell me what went wrong??

[Cronus1007]

@rohan-goel Have a look at these two ss . One is from the code of cc-chooser repo and one from yours. You mistakenly made few changes in the StepHeader.vue. Resolve these conflicts tests will be working fine.

[rohan-goel]

Thanks for your help @Cronus1007 .

[Cronus1007]

@rohan-goel Plzzz update your branch to resolve the merge conflicts.

[obulat]

Thank you for your contribution, @rohan-goel ! The code looks much cleaner now :)

[rohan-goel]

Thanks, @obulat !!