-
-
Notifications
You must be signed in to change notification settings - Fork 180
Linting and code formatting #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
obulat
merged 11 commits into
creativecommons:master
from
rohan-goel:Linting-and-formatting
Feb 26, 2021
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4402379
added prettier and changed indent
rohan-goel 572b047
added stylelint
rohan-goel 91ec5d1
added pre-commit
rohan-goel 14501df
Improvements
rohan-goel 3840ebd
resolve merge conflicts
rohan-goel ed2f65a
Merge remote-tracking branch 'upstream/master' into Linting-and-forma…
rohan-goel 75db15c
Temporarily disable pre-commit hook to allow rebase
obulat b3a2575
Merge branch 'master' into Linting-and-formatting
obulat d13fa8c
Re-enable pre-commit hook after merge
obulat a39b279
Lint merged files
obulat a7dbfb5
Add comma-dangle multiline rule
obulat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,42 @@ | ||
| module.exports = { | ||
| root: true, | ||
| env: { | ||
| node: true | ||
| }, | ||
| extends: [ | ||
| 'plugin:vue/recommended', | ||
| '@vue/standard' | ||
| ], | ||
| rules: { | ||
| 'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off', | ||
| 'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off', | ||
| indent: ['error', 4], | ||
| 'space-before-function-paren': ['warn', 'never'], | ||
| 'vue/require-default-prop': 'off', | ||
| 'vue/no-v-html': 'off', | ||
| 'vue/html-indent': ['error', 4] | ||
| }, | ||
| parserOptions: { | ||
| parser: 'babel-eslint' | ||
| }, | ||
| overrides: [ | ||
| { | ||
| files: [ | ||
| '**/__tests__/*.{j,t}s?(x)', | ||
| '**/tests/unit/**/*.spec.{j,t}s?(x)' | ||
| ], | ||
| env: { | ||
| jest: true | ||
| } | ||
| } | ||
| ] | ||
| root: true, | ||
|
|
||
| env: { | ||
| node: true, | ||
| browser: true | ||
| }, | ||
|
|
||
| rules: { | ||
| 'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off', | ||
| 'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off', | ||
| indent: ['error', 2], | ||
| 'space-before-function-paren': ['warn', 'never'], | ||
| 'vue/require-default-prop': 'off', | ||
| 'vue/no-v-html': 'off', | ||
| 'vue/html-indent': ['error', 2] | ||
| }, | ||
|
|
||
| parserOptions: { | ||
| parser: 'babel-eslint' | ||
| }, | ||
|
|
||
| overrides: [ | ||
|
|
||
| { | ||
| files: [ | ||
| '**/__tests__/*.{j,t}s?(x)', | ||
| '**/tests/unit/**/*.spec.{j,t}s?(x)' | ||
| ], | ||
| env: { | ||
| jest: true | ||
| } | ||
| } | ||
| ], | ||
|
|
||
| extends: [ | ||
| 'plugin:vue/recommended', | ||
| '@vue/standard', | ||
| 'prettier', | ||
| 'prettier/vue' | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.