-
-
Notifications
You must be signed in to change notification settings - Fork 180
Chore/add dockerised prettier #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/add dockerised prettier #580
Conversation
Similar to cc/search repo
Ignore vocabulary directory from upstream
Also re-add repo links
✅ Deploy Preview for creativecommons-chooser ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@dijitali Hi and thanks for this. The introduction of the docker web server here seems out of scope for the original Issue, which is just about implementing prettier only. I think the prettier node setup is all that would be needed to satisfy the requirements here. Though, its reasonable to create another Issue around Dockerizing the repo into a webserver vs opening a static file as an option, but we'd want to keep each scope of work separate here I believe. |
|
Ah gotcha. Removed the web server bits now. Now the project is so simplified with #570, it could just be simpler and more maintainable to leave docker out altogether and just say something like:
But 🤷, might be good to have a web server to catch CORS issues and the like. |
|
@dijitali It's fair. It's an evolving situation. Thanks for reducing it down! Can you also remove the changes to the For example: for input fields breaking attributes into newlines can be useful, but doing it other places can be cumbersome and harder for direct edit HTML. The balance with anything like prettier is that it often seems to lean a bit toward sorting out generated HTML in systems where the input lang is written in something else (like JS or Python, etc.). In the case of the Chooser we're writing HTML directly and I'd like it to be more friendly do direct editing and I'm not sure that some of the settings we have in the Search Portal are the greatest at that at the moment. |
This reverts commit dd86dab.
|
Sure thing, have reverted dd86dab. |
Fixes
Description
Reintroduces Prettier in a similar manner to the search repo as recommended in #520 (comment)
Technical details
Docker and prettier config lifted directly from search repo. Only modifications are:
node:bullseye-slimtonode:bookworm-slimimagevocabularyfiles in this repoTests
Follow the steps added to the README.md and confirm the experience is as expected.
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin