-
-
Notifications
You must be signed in to change notification settings - Fork 73
Added: Logging into Codebase for Improved Management #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
After you merge Pull Request #89 , It will only have the changes of Logging files and not all the file changes that it is currently showing. |
|
Adding Further Logging to the Files and committing here. |
|
Closing this Pull and doing all issues #89 , #85 , and #91 solutions in a single pull #95 .This will show you only the latest changes, with organized code, added logger, and shared module, to help you not get cluttered in the codebase with multiple changes. @TimidRobot |
|
@IamMQaisar I prefer commits and pull requests (PRs) to be as small as possible. Git is very effective at managing multiple changes. |
Actually, I've been working on 3 issues so that's also the reason of going through many commits, will be managing this next time more in local environment. About PRs, I noticed it myself and reduced those into 1 PR. 🙃 |
|
And my merging it into one pull to showcase changes was not for git but for the maintainer to go through it easily and solve the relevant issue as one whole. |
Fixes
Fixes #85 by @naishasinha
cc: @TimidRobot
Description
logging has been added to the Python scripts instead of using prints. Further Scripts are being also added to the commit to fully resolve the issue.
Review these files until then and provide feedback in case of changes required.
Technical details
import logginglibrary added.Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin