Skip to content

Conversation

@itisQaisar
Copy link
Contributor

Fixes

Fixes #85 by @naishasinha
cc: @TimidRobot

Description

logging has been added to the Python scripts instead of using prints. Further Scripts are being also added to the commit to fully resolve the issue.
Review these files until then and provide feedback in case of changes required.

Technical details

import logging library added.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there were no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@itisQaisar itisQaisar requested review from a team as code owners March 16, 2024 22:30
@itisQaisar itisQaisar requested review from TimidRobot and annatuma and removed request for a team March 16, 2024 22:30
@itisQaisar
Copy link
Contributor Author

After you merge Pull Request #89 , It will only have the changes of Logging files and not all the file changes that it is currently showing.

@itisQaisar itisQaisar changed the title Added [Feature] Integrate Python Logging into Codebase for Improved Management [WIP] Added: [Feature] Integrate Python Logging into Codebase for Improved Management Mar 17, 2024
@itisQaisar itisQaisar changed the title [WIP] Added: [Feature] Integrate Python Logging into Codebase for Improved Management [WIP] Added: Logging into Codebase for Improved Management Mar 17, 2024
@itisQaisar
Copy link
Contributor Author

Adding Further Logging to the Files and committing here.

@itisQaisar itisQaisar changed the title [WIP] Added: Logging into Codebase for Improved Management Added: Logging into Codebase for Improved Management Mar 17, 2024
@itisQaisar
Copy link
Contributor Author

Closing this Pull and doing all issues #89 , #85 , and #91 solutions in a single pull #95 .This will show you only the latest changes, with organized code, added logger, and shared module, to help you not get cluttered in the codebase with multiple changes. @TimidRobot

@itisQaisar itisQaisar closed this Mar 17, 2024
@TimidRobot
Copy link
Member

@IamMQaisar I prefer commits and pull requests (PRs) to be as small as possible. Git is very effective at managing multiple changes.

@itisQaisar
Copy link
Contributor Author

itisQaisar commented Mar 18, 2024

@IamMQaisar I prefer commits and pull requests (PRs) to be as small as possible. Git is very effective at managing multiple changes.

Actually, I've been working on 3 issues so that's also the reason of going through many commits, will be managing this next time more in local environment.
Thanks for the suggestion, as I was also noticing that.

About PRs, I noticed it myself and reduced those into 1 PR. 🙃

@itisQaisar
Copy link
Contributor Author

And my merging it into one pull to showcase changes was not for git but for the maintainer to go through it easily and solve the relevant issue as one whole.

@TimidRobot TimidRobot self-assigned this Mar 20, 2024
@itisQaisar itisQaisar deleted the logging branch April 2, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Integrate Python Logging into Codebase for Improved Management

2 participants