Skip to content

shared rollup config #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021
Merged

shared rollup config #3

merged 1 commit into from
Nov 17, 2021

Conversation

romainmenke
Copy link
Member

  • add a shared rollup config for both javascript and typescript.
  • this should support esm, cjs and cli's.

Notes :

  1. Some dependencies have circular imports and rollup nags about these.
    In practice they seem to work fine so I silence them after testing.

  2. Typescript support is added early here as I think it is an important tool.
    There is no plan to migrate everything to Typescript now. It should just be possible to use in this repo.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and I love you've opened the door to TS globally :)

Some comments, happy to discuss. Most of this would clash with ; for example on eslint

@Antonio-Laguna Antonio-Laguna merged commit 3fccd36 into main Nov 17, 2021
@Antonio-Laguna Antonio-Laguna deleted the shared-rollup-config branch November 17, 2021 09:15
romainmenke pushed a commit that referenced this pull request Mar 22, 2022
First walkthrough, initializing data model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants