Skip to content

postcss-preset-env : add cascade layers #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 19, 2022
Merged

postcss-preset-env : add cascade layers #374

merged 8 commits into from
May 19, 2022

Conversation

romainmenke
Copy link
Member

No description provided.

romainmenke
romainmenke commented May 12, 2022
View reviewed changes
romainmenke
romainmenke commented May 12, 2022
View reviewed changes
@romainmenke
Copy link
Member Author

Size diff with and without some cascade layers :

with cascade layers :

+--------------------------------------------------------------+
| Size         | 33.82 KiB                                     |
|--------------------------------------------------------------|
| Gzipped      | 5.26 KiB                                      |
+--------------------------------------------------------------+

without :

+--------------------------------------------------------------+
| Size         | 27.07 KiB                                     |
|--------------------------------------------------------------|
| Gzipped      | 5.04 KiB                                      |
+--------------------------------------------------------------+

Antonio-Laguna
Antonio-Laguna approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'm kind of nervous with this plugin because of how drastic the transformations are! Thanks for checking this so thoroughly

@romainmenke romainmenke mentioned this pull request May 16, 2022
Merged
@romainmenke romainmenke marked this pull request as ready for review May 18, 2022 15:38
@romainmenke
Copy link
Member Author

updated docs : https://github.com/csstools/postcss-plugins/blob/preset-env-add-cascade-layers--compassionate-giant-panda-bear-bf23b5ebc4/plugins/postcss-cascade-layers/README.md#how-it-works

Antonio-Laguna
Antonio-Laguna approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, love the docs, I think this definitely helps with #376

@romainmenke romainmenke merged commit bfd4db4 into main May 19, 2022
@romainmenke romainmenke deleted the preset-env-add-cascade-layers--compassionate-giant-panda-bear-bf23b5ebc4 branch May 19, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-Laguna Antonio-Laguna Antonio-Laguna approved these changes

Assignees
No one assigned
Labels
plugin-packs/postcss-preset-env plugins/postcss-cascade-layers plugins/postcss-nesting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainmenke @Antonio-Laguna