fix selector ordering with pseudo elements #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
May 16, 2022
Comment on lines
+10
to
+13
| assert.deepEqual(calculate(':before'), { a: 0, b: 0, c: 1 }); | ||
| assert.deepEqual(calculate('::before'), { a: 0, b: 0, c: 1 }); | ||
|
|
||
| assert.deepEqual(calculate(':focus'), { a: 0, b: 1, c: 0 }); |
There was a problem hiding this comment.
This package lacked sufficient coverage for pseudo elements vs classes.
| @@ -67,9 +67,6 @@ function selectorTypeOrder(selector, type) { | |||
| return selectorTypeOrderIndex.pseudoElement; | |||
| } | |||
|
|
|||
| if (type === 'pseudo' && selector && selector.indexOf('::') === 0) { | |||
There was a problem hiding this comment.
selectorParser.isPseudoElement(selector) on line 66 expects a Node and this didn't work before because it was a string.
This code on line 70 was insufficient but did work with strings.
Same change in all other plugins with similar logic.
| @@ -22,7 +22,7 @@ const creator: PluginCreator<pluginOptions> = (opts?: pluginOptions) => { | |||
|
|
|||
| return { | |||
| postcssPlugin: 'postcss-cascade-layers', | |||
| Once(root: Container, { result }: { result: Result }) { | |||
| OnceExit(root: Container, { result }: { result: Result }) { | |||
There was a problem hiding this comment.
see : #374
This change will likely be merged and released before we can add it to preset-env so adding it here as it is an obvious improvement.
Antonio-Laguna
approved these changes
May 17, 2022
|
Awesome work! Getting this out ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #382