stacktrace: include number of hidden frames

[blueyed]

No description provided.

[codecov]

Codecov Report

Merging #1072 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master    #1072   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files          24       24           
  Lines        1318     1318           
  Branches      178      178           
=======================================
  Hits         1111     1111           
  Misses        157      157           
  Partials       50       50

Impacted Files	Coverage Δ
debug_toolbar/panels/cache.py	81.19% <0%> (ø)	⬆️
debug_toolbar/panels/sql/tracking.py	83.83% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3725cec...5bd7513. Read the comment docs.

[matthiask]

I had to back this change out again in my local tests --

Traceback (most recent call last):                                                              
  File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)                                                            
  File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/django/utils/deprecation.py", line 142, in __call__
    response = self.process_response(request, response)
  File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/debug_panel/middleware.py", line 67, in process_response
    panel.generate_stats(request, response)                                                                                                            
  File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/debug_toolbar/panels/sql/panel.py", line 215, in generate_stats             
    query['stacktrace'] = render_stacktrace(query['stacktrace'])                                                                                                   
  File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/debug_toolbar/utils.py", line 72, in render_stacktrace
    trace, hidden_count = trace           
ValueError: too many values to unpack      

trace contains a HTML string it seems.

[matthiask]

I do think this change is interesting by the way, but it seems reopening pull requests after merging isn't possible.

[blueyed]

Yeah, you could have reverted it through Github's UI maybe.

I will create a new PR, but without any fix yet: #1095.

[matthiask]

Oh indeed, you're right. I hadn't seen that button yet.