Skip to content

stacktrace: include number of hidden frames #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Sep 7, 2018

Re-opening #1072.

TODO:

  • bug (stacktrace: include number of hidden frames #1072 (comment))

    Traceback (most recent call last):                                                              
      File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/django/core/handlers/exception.py", line 41, in inner
        response = get_response(request)                                                            
      File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/django/utils/deprecation.py", line 142, in __call__
        response = self.process_response(request, response)
      File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/debug_panel/middleware.py", line 67, in process_response
        panel.generate_stats(request, response)                                                                                                            
      File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/debug_toolbar/panels/sql/panel.py", line 215, in generate_stats             
        query['stacktrace'] = render_stacktrace(query['stacktrace'])                                                                                                   
      File "/home/matthias/Projects/sites/***/venv/local/lib/python2.7/site-packages/debug_toolbar/utils.py", line 72, in render_stacktrace
        trace, hidden_count = trace           
    ValueError: too many values to unpack      
    

    trace contains a HTML string it seems.

Base automatically changed from master to main February 11, 2021 15:01
@auvipy
Copy link
Contributor

auvipy commented Oct 25, 2021

what issues does this need to be fixed

@blueyed
Copy link
Contributor Author

blueyed commented Oct 25, 2021

what issues does this need to be fixed

IIRC this was meant as a placeholder/reminder for #1072, which was reverted back then. The issue this fixed/improved was to add an indicator for hidden frames.
Feel free to turn it into an issue (closing it for now).

@blueyed blueyed closed this Oct 25, 2021
@blueyed blueyed deleted the hidden-count-2 branch October 25, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants