Enable selenium on travis #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hmm, this has broken travis. |
Member
Author
|
There we go. It's not as clean as I expected, I didn't realize we also had to install |
Closed
jdufresne
reviewed
Sep 26, 2020
Member
Author
|
Nope, I missed that.
|
jdufresne
approved these changes
Sep 26, 2020
Contributor
jdufresne
left a comment
There was a problem hiding this comment.
Otherwise, LGTM. Thanks!
Ignores the selenium logfile that's created for firefox.
It makes sense to run the selenium tests in the ideal configuration which is postgres and latest stable version of django. Remove selenium version limitation. Pass through the TRAVIS and DJANGO_SELENIUM_TESTS environment variables. Use headless mode for selenium when testing via Travis. Install geckodriver before running selenium tests.
Member
Author
|
Updated to reference v0.27.0 of geckodriver. |
Member
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1251