added functionality to keep unsort the session dict - #1673
Merged
Conversation
matthiask
reviewed
Sep 18, 2022
matthiask
left a comment
Member
There was a problem hiding this comment.
Looks good! I think you're only verifying the failing case though, maybe add a second test where the session contains only string keys (which can actually be sorted)?
tim-schilling
requested changes
Sep 20, 2022
tim-schilling
left a comment
Member
There was a problem hiding this comment.
Thank you for opening a PR! Please add a mention of this change in docs/changes.rst. That helps reduce effort in releasing new versions.
Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
for more information, see https://pre-commit.ci
tim-schilling
approved these changes
Sep 25, 2022
Member
|
Thank you for the work on this @ritiksoni00! |
Contributor
Author
sorry, tim for not responding.. ! |
Member
|
No worries, thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1668