Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions debug_toolbar/panels/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,12 @@ def generate_stats(self, request, response):
self.record_stats(view_info)

if hasattr(request, "session"):
self.record_stats(
{
"session": {
"list": [
(k, request.session.get(k))
for k in sorted(request.session.keys())
]
}
}
)
try:
session_list = [
(k, request.session.get(k)) for k in sorted(request.session.keys())
]
except TypeError:
session_list = [
(k, request.session.get(k)) for k in request.session.keys()
]
self.record_stats({"session": {"list": session_list}})
19 changes: 19 additions & 0 deletions tests/panels/test_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,22 @@ def test_namespaced_url(self):
self.panel.generate_stats(self.request, response)
panel_stats = self.panel.get_stats()
self.assertEqual(panel_stats["view_urlname"], "admin:login")

def test_session_list_sorted_or_not(self):
"""
Verify the session is sorted when all keys are strings.

See https://github.com/jazzband/django-debug-toolbar/issues/1668
"""
self.request.session = {
1: "value",
"data": ["foo", "bar", 1],
(2, 3): "tuple_key",
}
data = {
"list": [(1, "value"), ("data", ["foo", "bar", 1]), ((2, 3), "tuple_key")]
}
response = self.panel.process_request(self.request)
self.panel.generate_stats(self.request, response)
panel_stats = self.panel.get_stats()
self.assertEqual(panel_stats["session"], data)
Comment thread
ritiksoni00 marked this conversation as resolved.