Fixes #2073 -- Added DatabaseStore for persistent debug data storage. #2121
Conversation
- Introduced `DatabaseStore` to store debug toolbar data in the database. - Added `DebugToolbarEntry` model and migrations for persistent storage. - Updated documentation to include configuration for `DatabaseStore`. - Added tests for `DatabaseStore` functionality, including CRUD operations and cache size enforcement. Fixes django-commons#2073
|
Tests are all failing, you'd probably have to do a merge of |
|
The only failing tests are unrelated to this PR. Both tests have already been fixed, but the fixes have not yet been merged into the serializable branch. |
- Updated model name from `DebugToolbarEntry` to `HistoryEntry` to make string representations of the app_model less redundant. - Adjusted verbose names to use translations with `gettext_lazy`. - Updated all references in `store.py` to use the new model name. - Modified tests to reflect the model name change. - Added a test to check the default ordering of the model and make it the defaul ordering in methods reliable.
Fix verbose names and capitalization.
Fix verbose name
|
By the way, you could try pinning django-csp<4 in this branch again, this would probably allow the tests to pass. And you don't have to worry about merging main for now. |
|
Good. I'll try pinning CSP. That way, I can also rest assured that's the only cause of the failing tests. |
|
I'll look into the failing (MySQL) tests later today. Good that we pinned django-csp. Otherwise, I would have assumed that was the only reason for the failing tests. |
|
The MariaDB failure has to do with using |
|
I applied some of the changes suggested by @tim-schilling without attempting to simplify tests yet to see if all tests pass in CI. |
|
@tim-schilling I'm good with this, and I hope we can get |
This doesn't provide the same utility as it does for the memory store. We need to use get_or_create to generate the entry in the database regardless. The middleware will be using .set() to trim extra requests to avoid overflowing the store removing the need for save_panel to also do the same.
Description
DatabaseStoreto store debug toolbar data in the database.DebugToolbarEntrymodel and migrations for persistent storage.DatabaseStore.DatabaseStorefunctionality, including CRUD operations and cache size enforcement.Fixes #2073
Checklist:
docs/changes.rst.