Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2073 -- Added DatabaseStore for persistent debug data storage. #2121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: serializable
Are you sure you want to change the base?
Fixes #2073 -- Added DatabaseStore for persistent debug data storage. #2121
Changes from 1 commit
6b54dca
17b27ce
a020331
4e71a4a
d37468f
677a80a
9d25201
4aadebe
fff3fae
d3329d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to
set()
, do we want to usetransaction.atomic()
here as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is showing under panel()... I wonder if somehow the comment shifted and it was meant for save_panel().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant this comment for both methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per our call, there's a concern about panels updating this concurrently and needing to avoid clearing another panel's data when saving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what the
set
method is for. @tim-schilling , do you remember what the thinking behind it was when we havesave_panel
to really do saving?The call can probably be removed here because we're immediately doing
get_or_create
afterwards, so if the entry doesn't exist already saving the panel data works anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll push the rest of changes for now, while this is being discussed.
For reference, here's our the
save_panel
method was implemented in MemoryStore, including theset
method call.We can also call
_cleanup_old_entries
directly rather thanset
to call_cleanup_old_entries
, if I understand the purpose correctly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cls.set()
is meant to create the record for the request in the toolbar's store. For theMemoryStore
, there's a separate collection of ids from the actual store. I suspect it's for performance more than anything.