Fixed cookie expires calculation - #2377
Merged
Merged
Conversation
expiries.setDate() was returning NaN, causing all cookies to be set without an expiry date and falling back to session-scoped cookies.
Contributor
Author
|
I don't really have enough context to add test for this specific case 😭 |
for more information, see https://pre-commit.ci
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
expiries.setDate() was returning NaN, causing all cookies to be set without an expiry date and falling back to session-scoped cookies. So all the user settings will get erase when the restart the browser
The first 3 cookies was set before the fix, all have
sessionas expiryLast 2 two is after the fix, which have correct expiry date
Checklist:
docs/changes.rst.