Skip to content

Fixed cookie expires calculation #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-schilling merged 4 commits into from
May 25, 2026
Merged

Fixed cookie expires calculation #2377

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d75faaf
fix cookie expiry calculation
leduythuccs May 22, 2026
6853ec0
Update docs/changes.rst
leduythuccs May 22, 2026
8b8d6cf
Update docs/changes.rst
tim-schilling May 25, 2026
9ec076f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix cookie expiry calculation 
expiries.setDate() was returning NaN, causing all cookies to be set without an expiry date and falling back to session-scoped cookies.
  • Loading branch information
@leduythuccs
leduythuccs authored May 22, 2026
commit d75faafae409b37999a702ce29e4482bcd735764
2 changes: 1 addition & 1 deletion debug_toolbar/static/debug_toolbar/js/toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ const djdt = {
if (typeof options.expires === "number") {
const days = options.expires;
const expires = new Date();
expires.setDate(expires.setDate() + days);
expires.setDate(expires.getDate() + days);
options.expires = expires;
}

Expand Down