Handle cache culling and boolean lookup changes in Django 6.2 - #2385
Conversation
849b0f1 to
3930b94
Compare
|
I reverted the test change to evaluate against the SQL. While I think it's better, I'm not sure how to test that reliably 😅 |
Coverage report
This PR does not seem to contain any modification to coverable code. |
5e4de08 to
bff52ac
Compare
Coverage Report
File CoverageNo changed files found. |
webdriverio has a higher configuration cost and there's currently a bug with GitHub actions, linux and chrome that makes it annoying. Switching to playwright should side-step that all. Explicitly mention the emnapi packages to ensure they show up in the lock file for runs on linux.
e0173cc to
2818332
Compare
| neo | ||
| nothreading | ||
| paddings | ||
| postgresql |
There was a problem hiding this comment.
| postgresql | |
| PostgreSQL |
| "@emnapi/core": "^1.11.1", | ||
| "@emnapi/runtime": "^1.11.1" |
There was a problem hiding this comment.
I don't see those imported anywhere.
There was a problem hiding this comment.
They are only needed by linux builds, so when someone updates the dependencies on a mac, it removes them and then it breaks in CI. I mentioned this in the commit message so someone can understand via git blame in the future.
| - name: Install Node dependencies | ||
| run: npm ci | ||
| - name: Install Playwright browsers | ||
| run: npx playwright install --with-deps chromium firefox |
There was a problem hiding this comment.
The browsers are stock on GH's ubuntu-latest images.
And playwright should be installed via npm ci, right?
There was a problem hiding this comment.
It's what the playwright docs suggest: https://playwright.dev/docs/ci-intro#setting-up-github-actions
There was a problem hiding this comment.
Hm… you might end up with different versions. I don't know if those NPN deps do any funny install script magic, but the browsers and their web drivers should already be installed.
You can try w/o the line, or consider adding the deps to the package.json file.
There was a problem hiding this comment.
I also run playwright install in CI runs. I could be wrong but I think it's the way to go.
Co-authored-by: Johannes Maron <johannes@maron.family> Co-authored-by: Matthias Kestenholz <matthiask@fastmail.com>
Description
This should fix the build for the tests against main.
Checklist:
docs/changes.rst.AI/LLM Usage