Skip to content

Handle cache culling and boolean lookup changes in Django 6.2 #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthiask merged 4 commits into from
Jun 16, 2026
Merged

Handle cache culling and boolean lookup changes in Django 6.2 #2385

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
198304a
Account for Django cache culling probability.
tim-schilling Jun 13, 2026
577358d
Support Django 6.2's handling of booleans for non-postgresql databases.
tim-schilling Jun 14, 2026
2818332
Switch to playwright for the vitest provider.
tim-schilling Jun 14, 2026
5651ae2
Apply capitalization to the PostgreSQL database name
matthiask Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch to playwright for the vitest provider. 
webdriverio has a higher configuration cost and there's currently a bug
with GitHub actions, linux and chrome that makes it annoying. Switching
to playwright should side-step that all.

Explicitly mention the emnapi packages to ensure they show up in the lock file for runs on linux.
  • Loading branch information
@tim-schilling
tim-schilling committed Jun 15, 2026
commit 281833271fb1935de78ab48452f29eb9f5606775
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:
cache-dependency-path: package-lock.json
- name: Install Node dependencies
run: npm ci
- name: Install Playwright browsers
run: npx playwright install --with-deps chromium firefox

@codingjoe codingjoe Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The browsers are stock on GH's ubuntu-latest images.
And playwright should be installed via npm ci, right?

@tim-schilling tim-schilling Jun 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what the playwright docs suggest: https://playwright.dev/docs/ci-intro#setting-up-github-actions

@codingjoe codingjoe Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm… you might end up with different versions. I don't know if those NPN deps do any funny install script magic, but the browsers and their web drivers should already be installed.
You can try w/o the line, or consider adding the deps to the package.json file.

@matthiask matthiask Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also run playwright install in CI runs. I could be wrong but I think it's the way to go.

- run: npm test
- uses: davelosert/vitest-coverage-report-action@02f3c2e641286b7fa308cd3e430783103ce6103b # v2.12.0

Expand Down
Loading
Loading