Skip to content

Add reloadAll and cssModules to typings #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2018

Conversation

Nilos
Copy link

@Nilos Nilos commented Oct 9, 2018

No description provided.

@Nilos Nilos requested a review from ScriptedAlchemy as a code owner October 9, 2018 07:47
Copy link
Collaborator

@ScriptedAlchemy ScriptedAlchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ScriptedAlchemy ScriptedAlchemy changed the base branch from master to css-module-oneof-hmr October 9, 2018 17:24
@ScriptedAlchemy ScriptedAlchemy merged commit ee15791 into faceyspacey:css-module-oneof-hmr Oct 9, 2018
@ScriptedAlchemy
Copy link
Collaborator

Will publish this with the next batch of changes

@Nilos Nilos deleted the patch-1 branch October 10, 2018 11:37
ScriptedAlchemy added a commit that referenced this pull request Oct 23, 2018
* fix: Fixed HMR issue when oneOf is used

When using oneOf, HRM is never activated. This patch improved the lookup system used for determining
if CSS can and should be reloaded. There have been some other tweaks for css modules and HMR

fix #98,#80

* fix: Applying rollback fixes to updateWebpackConfig, search loader and use object keys

* fix: Adding back exported out hot loader

* docs(readme): Adding example of manual hotloader implementation

In the event users cannot get it to work, theres an example in the docs to reference

* fix: handle functions as loaders

Do not break when searching through `use` or `loader` that is a function

* fix(index.js): Support function loaders (#116)

* docs(readme): Tone of Voice clairification on what hot:true does (#113)

* fix(index.js): Support function loaders

updateWebpackConfig previously expected `use` entries to be strings or arrays, and would throw `needle.includes is not a function` errors when given a function that returns a loader object.

* Update README.md

* test: Fixing function-loader tests

* Add reloadAll and cssModules to typings (#115)

* docs(readme): Tone of Voice clairification on what hot:true does (#113)

* Add reloadAll and cssModules to typings
@faceyspacey
Copy link
Owner

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants