Fix #127: Don't ignore removeDuplicates option when using officialSorting

[mpsijm]

Pull Request Name

Description

The check for removing duplicates is completely separate from the sorting, even when {officialSorting: false}. Therefore, it shouldn't harm to also execute this check when {officialSorting: true}.

Fixes #127

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• This change requires a documentation update

How Has This Been Tested?

• I've added the following test: <div class="h-4 h-4 w-4">Using official sorting, with duplicates</div> with config {officialSorting: true} (removeDuplicates is true by default).

Test Configuration:

• OS + version: Arch Linux (last upgraded today)
• NPM version: 8.5.5
• Node version: 16.15.1

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[francoismassart]

👋 Hi @mpsijm ,

thank you for your contributions.

Both remaining PR looks fine and I'll merge them in the following days, just to make sure nobody complains between releases.

Our team at my main job has been reduced so I have less opportunities to spend time on the plugin but I hope this is temporary 😉

[francoismassart]

👋 @mpsijm,
I'll include your changes inside the previous PR #132 which will:

• Support classnames generated by plugin(s)
• Deprecate officialSorting and prependCustom, always considered to be true (required in order to support plugins)
• FIX multiples bugs listed in the PR no-custom-classname plugin support #132
• and also keep removeDuplicates option

I'll publish a beta version soon and collect feedback from our users.

Thanks again for your contributions 🙏

[francoismassart]

I just published a beta version with the fixes listed on #132
https://github.com/francoismassart/eslint-plugin-tailwindcss/tree/fix/no-custom-classname-plugin-support#readme

npm i eslint-plugin-tailwindcss@3.6.0-beta.0

Please give it a try and provide feedback and or issues 👍
Thank you