Add support for AMD (asynchronous module definition)#40
Merged
le717 merged 1 commit intogabceb:masterfrom Nov 7, 2014
Merged
Conversation
Contributor
|
Ref #18 just for logging purposes. ;) |
Contributor
|
@jcbrand I guess I should have asked this earlier: I assume you have successfully tested this in an/your AMD environment? |
Contributor
Author
|
@le717 Yes, this is being used in converse.js |
Contributor
|
The changes look good, but I'm having to track down some regressions right now, so I can't merge this quite yet. I'll get it in as soon as I can, though, as it is requested and a desired feature. Sorry about that and the long wait already! :( |
Contributor
Author
|
Thanks for the update. |
le717
pushed a commit
that referenced
this pull request
Nov 7, 2014
Add support for AMD (asynchronous module definition)
Contributor
|
While the regressions I mentioned still exist, this does not affect fixing them, so I went ahead and merged it. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for AMD, as used by module loaders such as require.js (with fallback in case a module loader is not present).
I see in #38 that you are considering removing the coffeescript file, so I didn't bother modifying that file as well.
Let me know if anything else is required.
Thanks
JC