implement warningWhenNotFound option #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should really try to keep this inline with the Babel version of the library. |
|
Thanks for the fast response! I agree with what you proposed there. I will change this to use |
|
Closing to favor #249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements what was suggested in #209. I'm still not 100% buying how the two options interact with each other since you have to manually disable
errorWhenNotFoundand enablewarningWhenNotFound. Ideally I would like to have a way to specify the log level when a class is not found, but maybe keeping backwards compatibility is more valuable and we can afford this redundancy. Thoughts?