implement handleNotFoundStyleName #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pechitook
commented
Jul 26, 2017
README.md
Outdated
|
|
||
| - `'throw'` will throw an error | ||
| - `'log'` will log a warning to the console | ||
| - `'ignore'` will silently ignore it |
There was a problem hiding this comment.
I think this list of available parameters could be improved, but nothing good happens after 2am. Open to ideas.
There was a problem hiding this comment.
Actually I think the wording used to define each option is a bit redundant, but if you think it is understandable it's good enough :)
There was a problem hiding this comment.
No, it is perfect.
Is this ready to be merged?
There was a problem hiding this comment.
I added tests and also tested locally against my project, so yes!
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #248, this enables different levels of logging when a class is not found:
throw,log, andignore.