Closed
Conversation
On the iPad, there's often a 1 pixel line at the edge of the arrow. Fix this for the top position only.
Fix a graphical bug in Firefox - Should fix hojberg#24
Owner
|
Sorry for taking so long to get back to you on this. Could you rebase and add tests for this? |
On the iPad, there's often a 1 pixel line at the edge of the arrow. Fix this for the top position only.
Author
|
Are you happy for the fix to only apply to the top position? |
Owner
|
@bensummers Im ok to apply just that if it works. However it seems like a hack? The problem exists because zooming does subpixel rendering on the ipad. To merge this, I need some specs to exercise this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the iPad, there's often a 1 pixel line at the edge of the arrow. There's an easy fix for the top position, but the other ones are more complex. This commit implements that easy fix, but the other positions still show the problem.